Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): scrollbar moves ODD content left #14473

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(app): scrollbar moves ODD content left #14473

merged 1 commit into from
Feb 15, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 12, 2024 •
edited
Loading

closes RQA-2329

Overview

prevent scrollbar presence from moving ODD content left

Test Plan

  • navigate to scrollable route on ODD (ex: Settings tab)
  • scroll up and down
  • observe that content remains fixed even with presence of scrollbar
Screen.Recording.2024-02-12.at.11.10.10.AM.mov

Changelog

Risk assessment

low

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce940e8) 67.78% compared to head (70bb53b) 67.82%.
Report is 6 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14473      +/-   ##
=======================================================
+ Coverage                67.78%   67.82%   +0.03%     
=======================================================
  Files                     2519     2519              
  Lines                    72002    72227     +225     
  Branches                  9256     9378     +122     
=======================================================
+ Hits                     48806    48986     +180     
- Misses                   20994    21018      +24     
- Partials                  2202     2223      +21
Flag Coverage Δ
app 64.75% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/App/OnDeviceDisplayApp.tsx 76.66% <0.00%> (ø)

... and 14 files with indirect coverage changes

@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 12, 2024 16:17
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 12, 2024 16:17
@ncdiehl11 ncdiehl11 requested review from TamarZanzouri and removed request for a team February 12, 2024 16:17
koji
koji reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nick, thank you for fixing this.

one quick question, is this working as well as on a Flex/Dev kit?

@koji koji requested review from a team and removed request for TamarZanzouri February 14, 2024 15:29
mjhuff
mjhuff approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works on a Flex. LGTM! Thank you!

@ncdiehl11 ncdiehl11 merged commit c5fc1bb into chore_release-7.2.0 Feb 15, 2024
27 of 28 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_odd-scrollabar-moving-content branch February 15, 2024 16:19
TamarZanzouri pushed a commit that referenced this pull request Feb 16, 2024
@ncdiehl11 @TamarZanzouri
fix(app): prevent scrollbar presence from moving ODD content left (#1…
f6fb749 
…4473)

closes RQA-2329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji left review comments

@mjhuff mjhuff mjhuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @mjhuff